2016-07-06 15:32 GMT-07:00 Guru Shetty <g...@ovn.org>:
> On 6 July 2016 at 05:38, Paul Boca <pb...@cloudbasesolutions.com> wrote:
>
> > Disable the syslog logger in case on Windows, '/dev/log' doesn't exist.
> > Seems like on Python34 a default handler is added to the logger and it
> > prints
> > even if no handler is set by us.
> >
> > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com>
> > ---
> > V3: Initial commit
> > V4: No changes
> > V5: No changes
> > V6: No changes
> > ---
> > python/ovs/vlog.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/python/ovs/vlog.py b/python/ovs/vlog.py
> > index 4996387..49210b8 100644
> > --- a/python/ovs/vlog.py
> > +++ b/python/ovs/vlog.py
> > @@ -301,6 +301,7 @@ class Vlog(object):
> > # If there is no infrastructure to support python syslog,
> increase
> > # the logging severity level to avoid repeated errors.
> > if not os.path.exists("/dev/log"):
> > + logger.disabled = True
> > logger.setLevel(logging.CRITICAL)
> >
>
> Would it have made sense to remove the above line and update the comment.
>
>
Good point, since I already merged the patch I've sent a follow-up here:
http://openvswitch.org/pipermail/dev/2016-July/074669.html
Thanks,
Daniele
> > return
> >
> > --
> > 2.7.2.windows.1
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
