On Sat, May 21, 2016 at 9:12 AM, Jesse Gross <je...@kernel.org> wrote:
> On Wed, May 4, 2016 at 4:35 PM, Pravin B Shelar <pshe...@ovn.org> wrote:
>> From: Pravin B Shelar <pshe...@nicira.com>
>>
>> There is return type change in upstream handle-offload functions.
>> Following patch brings these changes in.
>>
>> Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
>
> I think at this point, I need to ask you to align these patches with
> upstream commits as we have done in recent history for backports. It's
> very hard to review as they are grouped here since the code doesn't
> really correspond to any point in upstream and I also don't know
> whether anything from other commits has been missed. In this case,
> this patch mostly is a backport of aed069df ("ip_tunnel_core:
> iptunnel_handle_offloads returns int and doesn't free skb") but not
> exactly since it is out of order with respect to other upstream
> commits and with some OVS changes mixed it.I did not aligned patches with upstream patches to make it easier for review since you just need to compare to latest net branch. There might be some changes in upstream code since I backported these patches, but those should be pretty minor. If I break it down according to upstream commits you will need to check with each upstream patch and then compare the kernel module with net branch to see if any commit it missing. So it is easier this way. If you still want it to breakup patches according to the commits I can send updated series. Specifically about this patch, which part is not related to the commit aed069df? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
