On 01/06/2016 11:32 AM, Ben Pfaff wrote: > On Wed, Jan 06, 2016 at 10:19:56AM -0500, Russell Bryant wrote: >> On 01/06/2016 06:29 AM, Numan Siddique wrote: >>> with the flake8 check enabled, ovs compilation is failing. This >>> patch adds few more flake8 types to the igore list. >>> >>> Signed-off-by: Numan Siddique <nusid...@redhat.com> >> >> Thanks for the patch! After some discussion on IRC and more testing, I >> pushed this to master with some minor additions. >> >> The issue turned out to be flake8 plugins. My laptop did not have the >> docstrings and hacking flake8 plugins, which generate these additional >> errors. Unfortunately, I don't see a way to configure flake8 with an >> explicit list of plugins to use, so we just get whatever is installed. > > Would it work better to whitelist the warnings we want, with --select, > instead of blacklisting the warnings we don't want with --ignore? >
Maybe ... I'm not sure how to get a list. It could be hundreds of entries long. We also wouldn't get new ones as they get added in upgrades. I was able to come up with a minor improvement. --ignore=E123,E126,E127,E128,E129,E131,W503,D,H This ignores all of D*** and H***. This would have been a little better, but the --select overrides the --ignore here, so it didn't behave how I wanted. --select=E,W,F --ignore=E123,E126,E127,E128,E129,E131,W503 I'll post a patch in a minute. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
