On 01/06/2016 06:29 AM, Numan Siddique wrote: > with the flake8 check enabled, ovs compilation is failing. This > patch adds few more flake8 types to the igore list. > > Signed-off-by: Numan Siddique <nusid...@redhat.com>
Thanks for the patch! After some discussion on IRC and more testing, I pushed this to master with some minor additions. The issue turned out to be flake8 plugins. My laptop did not have the docstrings and hacking flake8 plugins, which generate these additional errors. Unfortunately, I don't see a way to configure flake8 with an explicit list of plugins to use, so we just get whatever is installed. If these system differences continue to be painful, the cleanest solution would be to switch back to using 'tox', which will run flake8 in a consistently created virtual environment. The biggest downside is that it requires internet access to download packages when creating the virtualenv, and I don't think that requirement exists for any other part of the ovs build or test setup. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
