On 01/06/2016 07:46 PM, Russell Bryant wrote: > On 01/06/2016 06:47 AM, Numan Siddique wrote: >> I guess this patch is not required, once Russel's patches on - Python style >> fixes and flake8 integration >> are completely merged. > They are all merged now. What version of flake8 do you have? > > I had this originally: > > $ flake8 --version > 2.4.1 (pep8: 1.5.7, pyflakes: 0.8.1, mccabe: 0.3.1) CPython 2.7.10 on Linux > > I just upgraded and still don't see any new warnings: > > $ flake8 --version > 2.5.1 (pep8: 1.5.7, pyflakes: 1.0.0, mccabe: 0.3.1) CPython 2.7.10 on Linux > > I installed via pip. > > $ sudo pip install flake8 > > or to upgrade via pip, run: > > $ sudo pip install -U flake8 > > > Assuming it's just a version issue, we have a couple of choices: > > 1) Update the configure script to ensure some minimum version of flake8. > > 2) Go back to how I originally implemented this, which was to run flake8 > via 'tox', which ensures everyone uses the same version by automatically > creating/using a Python virtualenv and packages from PyPI. > > I think we should just try #1 unless this turns out to be painful for > some reason. >
I have 2.2.4 version. I will upgrade flake8 to latest version and test. I also see the failures in the openstack CI for networking-ovn for one of the patch [1] [1] - http://logs.openstack.org/26/178826/18/check/gate-tempest-dsvm-networking-ovn/cb05603/logs/devstacklog.txt.gz https://review.openstack.org/#/c/178826/ Thanks Numan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
