On Tue, Jul 28, 2015 at 04:36:29PM -0700, Justin Pettit wrote:
>
> > On Jul 28, 2015, at 8:44 AM, Ben Pfaff <b...@nicira.com> wrote:
> >
> > I found it otherwise difficult to see what code depended on this.
>
> It might be nice to explain that you care about the dependencies due
> to upcoming patches, since it wasn't immediately obvious to me why
> you'd care.
Good point. I changed the commit message to:
ovn-controller: Pass 'chassis_id' explicitly to functions that need it.
I found it otherwise difficult to see what code depended on this. When
later commits make it possible for ovn-controller to handle changes in
chassis ID, this will become important (the code should determine the
current chassis ID before trying to use it).
Signed-off-by: Ben Pfaff <b...@nicira.com>
> > diff --git a/ovn/controller/physical.h b/ovn/controller/physical.h
> > index 16d172b..3c86a7f 100644
> > --- a/ovn/controller/physical.h
> > +++ b/ovn/controller/physical.h
> > @@ -30,6 +30,7 @@ struct ovsrec_bridge;
> >
> > void physical_init(struct controller_ctx *);
> > void physical_run(struct controller_ctx *, const struct ovsrec_bridge
> > *br_int,
> > + const char *chassis_id,
> > struct hmap *flow_table);
>
> This adds whitespace to the end of the line. (I've always wanted to say that
> to you.)
>
> Not a big deal, but I think those lines can also be combined.
I joined the lines, thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
