I forgot to add my Ack: Acked-by: Justin Pettit <jpet...@nicira.com>
--Justin > On Jul 28, 2015, at 4:36 PM, Justin Pettit <jpet...@nicira.com> wrote: > > >> On Jul 28, 2015, at 8:44 AM, Ben Pfaff <b...@nicira.com> wrote: >> >> I found it otherwise difficult to see what code depended on this. > > It might be nice to explain that you care about the dependencies due to > upcoming patches, since it wasn't immediately obvious to me why you'd care. > >> diff --git a/ovn/controller/physical.h b/ovn/controller/physical.h >> index 16d172b..3c86a7f 100644 >> --- a/ovn/controller/physical.h >> +++ b/ovn/controller/physical.h >> @@ -30,6 +30,7 @@ struct ovsrec_bridge; >> >> void physical_init(struct controller_ctx *); >> void physical_run(struct controller_ctx *, const struct ovsrec_bridge >> *br_int, >> + const char *chassis_id, >> struct hmap *flow_table); > > This adds whitespace to the end of the line. (I've always wanted to say that > to you.) > > Not a big deal, but I think those lines can also be combined. > > --Justin > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
