> On Apr 8, 2015, at 8:34 AM, Russell Bryant <rbry...@redhat.com> wrote: > > On 04/08/2015 01:58 AM, Justin Pettit wrote: > >> By the way, would you be okay with our changing ovn-nbctl commands to >> more closely mimic ovs-vsctl? The main differences I see are >> changing the names of the following commands: >> >> lswitch-add -> add-lswitch >> lswitch-del -> del-lswitch >> lswitch-list -> list-lswitch >> lport-add -> add-lport >> lport-del -> del-lport >> lport-list -> list-lport > > I'm torn. I get the argument about making it match ovs-vsctl, but I > like the current naming better. :-) > > It does seem odd to swap those but leave the rest like > "lswitch-set-external-id", but I see that effectively makes it > consistent with ovs-vsctl, so I'm OK with it.
I like your naming convention better, too. Maybe we should add the aliases to ovs-vsctl. :-) I'm fine with leaving it as it is and we can revisit it if it actually trips people up. >> And, finally, change the order of the "lport-add" arguments so it >> would be "add-lport lswitch lport". > > Sounds good. This is the one that really was causing me issues, so if we can change that, I'd be very happy. >> It's pretty minor (and I realize your naming convention is more >> consistent), but I think it will cause less confusion when switching >> between the utilities. I'm happy to write up a patch if you want, >> but I imagine it will require changing the OpenStack portion, too, so >> I wanted to check with you. > > It will require changing the OpenStack code, but it will be a trivial > fix, so no big deal. Thanks! --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
