Alessandro, How the MSI solution find files from the OVS build that need to be included? Thanks, Eitan
-----Original Message----- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu Sent: Sunday, March 15, 2015 6:30 PM To: Alessandro Pilotti Cc: dev@openvswitch.org Subject: Re: [ovs-dev] OVS Windows MSI installer Alessandro, Yes, no problem of having the installer separate. But, I am confused as I see the two services are there but the driver and the INF file are not. I believe that the MSI file includes everything. Do you think you can add the OS installer script? Will we have already built MSI file (x86 and x86-64)? Thanks, Eitan -----Original Message----- From: Alessandro Pilotti [mailto:apilo...@cloudbasesolutions.com] Sent: Sunday, March 15, 2015 6:11 PM To: Eitan Eliahu Cc: dev@openvswitch.org Subject: Re: OVS Windows MSI installer Hi Eitan, > On 16 Mar 2015, at 02:57, Eitan Eliahu <elia...@vmware.com> wrote: > > > Hi Alessandro, > I couldn't find the driver binary as part of the installer. Also, can you > explain how uninstlaation is done and the case where a driver is already > loaded. As explained in the README, the actual binaries are produced by the OVS build, so it does not make sense to include them in this project, otherwise we’d need to commit the binaries at every OVS build. During uninstall the driver is removed. The general rule for Windows installers is that whatever gets installed, must be removed on uninstall (except user generated content, e.g. configuration files). I didn’t include the WMI / PowerShell call for deregistering the extension from Hyper-V switches yet, since infamously that operation generated a significant amount of crashes until very recently (we still have a pending patch on this topic AFAIK). Here is where the driver is uninstalled: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cloudbase_ovs-2Dwindows-2Dinstaller_blob_master_ovs-2Dwindows-2Dinstaller_Product.wxs-23L48-2DL49&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=WmmTcAbYsoZf0kKnbhjcKx6VU2dw-WDIcSF-V8Gtd94&s=ksjvS04wlV-fvUUTh7wLch51SUmIkKEpjAxRNZtebAw&e= Alessandro > Thank you! > Eitan > > -----Original Message----- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alessandro Pilotti > Sent: Sunday, March 15, 2015 5:33 PM > To: dev@openvswitch.org > Subject: [ovs-dev] OVS Windows MSI installer > > Hi guys, > > > > As discussed on IRC, here's the Windows MSI installer project that we’d like > to > > submit for upstream inclusion: > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cloudbase_ovs-2Dwindows-2Dinstaller&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=utkZq_G_Z0gpFYbAClV8e6AD4sXWL1oC5IbDSJwm-Dk&s=ssYlF73rox7Qc5jV0EuVGd31T3gjOjJrGilWxhpfCQU&e= > > > > > The included README.rst provides information on how to generate the MSI and > > I’ll also be happy to answer any question and review. > > > > In terms of location of the code, we could IMO either include the installer as > > a separate project on > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=utkZq_G_Z0gpFYbAClV8e6AD4sXWL1oC5IbDSJwm-Dk&s=j7vZQ7TETCqJcuj8GlWvxlDQj3eaZDowoeugOoF62m4&e= > or as a subfolder under > > the > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=utkZq_G_Z0gpFYbAClV8e6AD4sXWL1oC5IbDSJwm-Dk&s=64IUwcJqsI-IqUHcDpffloCd02L8ksBeDjCy2OB09So&e= > project itself. > > My vote is for the first option, but if you guys prefer the second I’ll be > > happy to send the full patchset on the ML for review. > > > > Thanks, > > > > Alessandro > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=utkZq_G_Z0gpFYbAClV8e6AD4sXWL1oC5IbDSJwm-Dk&s=Q9DuaqvXtQI-5E0ozVMau9cLqIUtEVFPGxNzhW5FhtU&e= > _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=E8G40dNCxrZ38oxXQmMUMaHyuhmF76rDGyoDLu_wGKE&s=ia3tRWFMlcRaiMrcYWBFlaohQfmUS0l1hHhy7z_lNSo&e= _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
