On Sun, Mar 15, 2015 at 5:33 PM, Alessandro Pilotti <apilo...@cloudbasesolutions.com> wrote: > Hi guys, > > As discussed on IRC, here's the Windows MSI installer project that we’d like > to > submit for upstream inclusion: > > https://github.com/cloudbase/ovs-windows-installer
Thank you for the contribution, Alessandro! I have a few questions after a quick browsing of the above repo. I have never written a Windows installer before, so some of my questions may look trivial. 1. What are the 2 executables in the below link? https://github.com/cloudbase/ovs-windows-installer/tree/master/ovs-windows-installer/Services Why do we need them? The way services handling code has been written in OVS is that it will need a workflow like this (example taken from tests/daemon.at): sc create ovsdb-server binpath="$abs_path/ovsdb-server `pwd`/db --log-file=`pwd`/ovsdb-server.log --pidfile=`pwd`/pid --remote=punix:`pwd`/socket --unixctl=`pwd`/unixctl --service --service-monitor" sc start ovsdb-server 2. I do not see anywhere in the repo where we run OVS initialization, like handling OVS database creation and initialization. (See start_ovsdb function in utilities/ovs-ctl.in on how we do it in Linux.) 3. Where do the log files get written? 4. How do we restart OVS services? (e.g. on Linux: /etc/init,d/openvswitch-switch restart). This would mean the need to upgrade the database with a different schema. Do we have an analogous thing to startup scripts in Windows? > > The included README.rst provides information on how to generate the MSI and > I’ll also be happy to answer any question and review. > > In terms of location of the code, we could IMO either include the installer as > a separate project on https://github.com/openvswitch or as a subfolder under > the https://github.com/openvswitch/ovs project itself. > My vote is for the first option, but if you guys prefer the second I’ll be > happy to send the full patchset on the ML for review. An ideal solution would be similar to how we create rpms and deb files for RHEL (rhel/* ) and Ubuntu (debian/* ). They are both in-tree in the OVS repo. So, in the ideal solution, we can create a MSI installer by running a command after running the 'make'. The command would automatically pick up all the required components (available through previous ./configure run) and create an installer out of it. It looks like it would be possible to do that (based on your README). It would also mean that it would be a OVS specific installer (I think your current code is a general purpose installer that you could use for multiple projects). Having a OVS specific installer may eventually be needed anyway because managing a OVS installation well would need all the things that we currently do in utilities/ovs-ctl.in for Linux. Thanks, Guru > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
