> > > > Generally we should describe subject in less than 70 characters. > > > Commit msg should explain why we are introducing this change. It is > > > not clear from the patch the relation between number of core on socket > > > and rx queues. > > > > > > > > > > Thx, I'll use the 70 characters rule, thought it was 80, > > 80 isn't too pushing the rules too much (sometimes it takes a few > extra characters to describe well), but the first line here is more > like 136 characters. >
I newline'ed the title line and it showed as two lines in my git log. i think git format-patch recombined them. anyway, i should use a short title and explain it in the commit log. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev