On Mon, Sep 01, 2014 at 11:41:24AM -0700, Alex Wang wrote:
> On Sat, Aug 30, 2014 at 12:02 PM, Pravin Shelar <pshe...@nicira.com> wrote:
> 
> > On Mon, Aug 11, 2014 at 9:56 PM, Alex Wang <al...@nicira.com> wrote:
> > > Before this commit, ovs only creates one tx/rx queue for each
> > > dpdk interface and uses only one poll thread for handling the
> > > I/O of all dpdk interfaces.  As one step toward using multiple
> > > poll threads, this commit makes ovs, by default, create same
> > > number of rx queues as the number dpdk interfaces on the cpu
> > > socket.  Also each dpdk interface will have one tx queue for
> > > each cpu core, even though not all of those queues will be
> > > used.
> > >
> >
> > Generally we should describe subject in less than 70 characters.
> > Commit msg should explain why we are introducing this change. It is
> > not clear from the patch the relation between number of core on socket
> > and rx queues.
> >
> >
> 
> Thx, I'll use the 70 characters rule, thought it was 80,

80 isn't too pushing the rules too much (sometimes it takes a few
extra characters to describe well), but the first line here is more
like 136 characters.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to