Hello Nithin, I'd like to highlight two points here: 1. the "datapath" on linux doesn't have all files Ovs-prefixed. I don't think there's a specific requirement for datapath-windows for that. 2. the "datapath" on linux uses a lot of functionality of the linux kernel (such as, the netlink protocol). My belief is that the datapath-windows will, in time, need more things added to it, things that the windows kernel API does not provide for us (one would be, windows netlink protocol), which would inevitably make the file structure more complex.
Sam ________________________________________ From: Nithin Raju [nit...@vmware.com] Sent: Wednesday, August 06, 2014 1:43 AM To: Eitan Eliahu Cc: Samuel Ghinet; dev@openvswitch.org Subject: Re: [ovs-dev] datapath-windows: Could we rename the files please? Sam, One thing to note is that there's thought that has gone into organizing the files by functionality, and the names of the files indicate so. For someone familiar with how a OVS datapath works, it should not take a lot of time to figure out which file implements a particular functionality. I don't know how much creating separate directories would buy us. A basis of comparison we have is to look at the kernel module on Linux. The code is fairly well organized by functionality and file names. There are not a whole lot of directories. Another basis of comparison is how lib/ is organized in userspace. But, I'd be interested in listening to a proposal. thanks, Nithin On Aug 5, 2014, at 2:48 PM, Eitan Eliahu <elia...@vmware.com> wrote: > Hi Sam, could you come up with some directory structure for the Move part? I > noticed you has a directory structure for your other driver. > Thanks, > Eitan > > -----Original Message----- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Samuel Ghinet > Sent: Tuesday, August 05, 2014 1:36 PM > To: dev@openvswitch.org > Subject: [ovs-dev] datapath-windows: Could we rename the files please? > > Hello guys, > > While we're still fresh with the windows kernel part, could we please rename > & move the files? > Rename: > All the files are Ovs-prefixed. The repository name is Ovs: It is obvious > that all files within it are Ovs. > Do we really need every file to be Ovs-prefixed? > > Move: > In time, I believe we should expect new files to be added. Perhaps we should > add folders in ovsext, such as Core (or whatever name you think best for > "needed everywhere stuff"), Protocol (for various net protocols), Transfer > (for Ingress, NBL management), HyperV (keep things such as functionality for > the Hyper-V Switch, Hyper-V Nics, Hyper-V Ports, OIDs), Winetlink (or > whatever name you prefer, for km-um) And, if we do this "move" operation into > folders, we would also create filters (i.e. logical folders) in the Visual > Studio Project file. > > I believe the movement of files into "component" based folder will help > modularize the project (i.e. people would less likely add Hyper-V Nic > functions in km-um files, buffer management in protocol files, etc.) > > Thanks! > Sam > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=pJELw5lpJP0zsKaXmHTIkD%2BGXGplbkr4HJyAX2bIF9M%3D%0A&s=a8fe7629ddafd79744993e6dcae1add9d664b67930a66becab1c7f34a68d4f37 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=x3NAfWhixTSOjgPxTVp6Ae1d3G%2FnQYLE1HGAx1mzHGM%3D%0A&s=ba46743fd6081512720bd67f48e308f31330d60ded61b677eada2a4393dd5c77 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
