On Fri, Jul 18, 2014 at 5:35 PM, Saurabh Shah <ssaur...@vmware.com> wrote: > > From: Ben Pfaff <b...@nicira.com> > Date: Wednesday, June 25, 2014 at 2:57 PM > To: Saurabh Shah <ssaur...@vmware.com> > Cc: "dev@openvswitch.org" <dev@openvswitch.org>, Guolin Yang > <gy...@vmware.com> > Subject: Re: [ovs-dev] [PATCH 1/4] datapath-windows: Base code for > developing the Hyper-V switch entension. > > On Mon, Jun 23, 2014 at 05:34:56PM -0700, Saurabh Shah wrote: > > This is the "Hyper-V Extensible Switch extension filter driver" sample code > available at: > https://urldefense.proofpoint.com/v1/url?u=http://code.msdn.microsoft.com/windowshardware/Hyper-V-Extensible-Virtual-e4b31fbb&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=a4cftGlf8vEwgrqFD%2BKga43CVdQlkcPWBAPG3X2DyDs%3D%0A&s=d21364b41493e68d2be1cad23274974b3f58f64e88cd45202ac88a13fe3e36b1 > The sample code is licensed under Microsoft Limited Public License version > 1.1. The license is available here - > https://urldefense.proofpoint.com/v1/url?u=http://msdn.microsoft.com/en-us/cc300389.aspx&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=a4cftGlf8vEwgrqFD%2BKga43CVdQlkcPWBAPG3X2DyDs%3D%0A&s=ced00f015947eba8c02feda4f05b51e875aa84fe8ceaa8f304b6c02b8b8351cc > (Exhibit B). > Our core Hyper-V switch extension builds on top of this sample code to > develop > the forwarding engine. > Signed-off-by: Eitan Eliahu <elia...@vmware.com> > Signed-off-by: Guolin Yang <gy...@vmware.com> > Signed-off-by: Linda Sun <l...@vmware.com> > Signed-off-by: Nithin Raju <nit...@vmware.com> > Signed-off-by: Saurabh Shah <ssaur...@vmware.com> > > > The authorship on this patch is a bit murky. It appears that > everything added in the patch was written by Microsoft (did VMware > modify it?), so why is it signed off by five VMware people? One, I > could understand, since someone has to compose the patch; whoever did > that should be the author of the patch. > > Unless Eitan or Nithin wrote up the patch, it's not time to add them > to AUTHORS. > > The license, not just a URL to it, should be included in the source > tree. I think that that is always a good idea, but 3(d) in the > license says so explicitly. > > I don't think that the URL you provide for the license is correct. > When I go to the URL for the code, then click on the MS-LPL link > there, I get slightly different text (e.g. the wording of 3(f) is > different there). > > I question whether we can include this in the source tree at all. > License 3(f) only allows distributing code "that run[s] directly on a > Microsoft Windows operating system product, ..." Source code doesn't > "run directly" on anything at all, so this might forbid distributing > source. I think we'd need to get a lawyer's opinion. Have you asked > a lawyer about that? > > 3(f) definitely violates DFSG #6 (see > https://urldefense.proofpoint.com/v1/url?u=https://www.debian.org/social_contract&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=a4cftGlf8vEwgrqFD%2BKga43CVdQlkcPWBAPG3X2DyDs%3D%0A&s=8ce646d020cff9d2758dc9b8de8da89744645d8eb4ac49acde2595a1fce54b28), > so if this code goes in then > it'll have to be removed during packaging for Debian upload. (I don't > know whether Fedora etc. have a similar policy.) > > > The licensing is a bit tricky. We made a call to rewrite the entire base > code. The new code will have no dependency on any of the MS-LPL code and > will be licensed under APACHE itself. I will submit a V2 patch with the new > base code & all your review comments sometime next week.
That's really good news. Rewriting the base code would set my mind at rest on that score. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
