On Wed, Jun 25, 2014 at 4:54 PM, Ben Pfaff <b...@nicira.com> wrote: > It looks like datapath-windows/include/OvsNetlink.h is cut-and-pasted > from other OVS header files, especially lib/netlink-protocol.h, > lib/netlink.h, and lib/util.h. Is it possible to reduce the amount of > code duplication? Either way, the copyright notice in that file > should include the original copyright notice years and authors, e.g. > * Copyright (c) 2008, 2009, 2010, 2011, 2013 Nicira, Inc. > for lib/netlink.h, instead of just saying VMware 2014.
I think that my advice to reduce code duplication here was misguided. It doesn't usually make sense to try to share code between user and kernel space, because the environments are quite different. I still think that the copyright notices should be updated. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
