On Mon, May 12, 2014 at 08:52:52AM -0700, Ben Pfaff wrote:
> On Mon, May 12, 2014 at 08:56:36AM +0900, Simon Horman wrote:
> > Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
> > be portable. Accordingly, use atomic_ulong instead of atomic_uint64_t
> > in struct ofproto.
> > 
> > This is in preparation for removing atomic_uint64_t entirely.
> > 
> > Cc: YAMAMOTO Takashi <yamam...@valinux.co.jp>
> > Signed-off-by: Simon Horman <ho...@verge.net.au>
> 
> Clang reports:

Thanks, I will fix this.

Could you let me know which version of clang you are using?
I do not seem to have any luck in getting clang to show my the
warnings below.

> 
>     ../ofproto/ofproto-dpif-upcall.c:488:1: error: conflicting types for
>           'udpif_get_n_flows'
>     udpif_get_n_flows(struct udpif *udpif)
>     ^
>     ../ofproto/ofproto-dpif-upcall.c:220:17: note: previous declaration is 
> here
>     static uint64_t udpif_get_n_flows(struct udpif *);
>                     ^
>     ../ofproto/ofproto-dpif-upcall.c:1603:48: error: format specifies type
>           'unsigned long' but the argument has type 'uint64_t' (aka
>           'unsigned long long') [-Werror,-Wformat]
>                 " (avg %u) (max %u) (limit %u)\n", udpif_get_n_flows(udpif),
>                                                    ^~~~~~~~~~~~~~~~~~~~~~~~
> 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to