Hi Ravi, I see following issues with datapath mpls support:
Actions: I do not see skb->csum updated when mpls action is performed on packet. Push / Set_lse action: You can compute mpls_lse value flow setup time in userspace. That will save time in every packet switching plus it simplifies code. we can easily do it for single label case. TTL actions: As Jesse has mentioned before there could be one Set action which should be able to handle three different ttl related actions added. e.g. OVS_ACTION_ATTR_COPY_TTL_IN can generate set-ipv4 action from userspace. OVS_ACTION_ATTR_COPY_TTL_OUT and OVS_ACTION_ATTR_DEC_MPLS_TTL can be set mpls action. This works for single label case. But ttl_in and ttl_out also needs mpls inner packet parsing in flow_extract to get exact flow in kernel datapath. Thanks, Pravin. On Tue, May 22, 2012 at 10:36 AM, <ravi.ke...@telekom.com> wrote: > Hi, > > > > Attached MPLS and VLAN QinQ patch after rebasing to following commit > > > > commit 046f1f89e6d7716581de207dd0c54421926bc25b > Author: Ethan Jackson <et...@nicira.com> > Date: Mon May 21 13:20:18 2012 -0700 > > > > Patch(s) have undergone additional integration testing and incorporates > initial code review comments from Ben. > > > > Thanks, > > Ravi > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
