I've made the changes you suggested. Due to the rebasing, I'm planning to resend the series in a bit.
Ethan On Thu, Mar 8, 2012 at 13:46, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Mar 07, 2012 at 05:09:25PM -0800, Ethan Jackson wrote: >> Typically Open vSwitch communicates with running processes using >> unixctl. This patch converts ovs-xapi-sync to the strategy for >> consistency. >> >> Signed-off-by: Ethan Jackson <et...@nicira.com> > > Seems reasonable but I have a few comments. > > In /etc/init.d/openvswitch, I'd use the daemon_is_running function > from ovs-lib.in instead of open-coding it. (Previously it had to be > open-coded because it needed the pid value.) > > Second, I think that the original purpose of SIGHUP has been forgotten > over time. It was introduced to flush the cache of data obtained from > the XAPI database. Somehow, we've come to present it as just a > general-purpose way to rerun the database logic, but in fact flushing > the cache is the only legitimate purpose in the absence of a bug > (although we've had plenty of those). > > So, I would change the name of the command, and the message that > ovs-xapi-sync logs, to reflect a cache flush, not just a rerun. > > Thanks, > > Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
