On Wed, Mar 07, 2012 at 05:09:24PM -0800, Ethan Jackson wrote:
> With this patch, users can query a running ovs-xapi-sync's version
> or ask it to exit using ovs-appctl.
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>

This code:
            poller = ovs.poller.Poller()

            unixctl_server.wait(poller)
            idl.wait(poller)
            poller.block()

            if exiting:
                poller.immediate_wake()

            continue

looks really weird to me, because it calls immediate_wake() on a
Poller instance that is never afterward used (presumably it gets
garbage collected).

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to