On Thu, Jan 12, 2012 at 11:40:01AM -0800, Ethan Jackson wrote:
> With this patch, when a user attempts to configure LACP with an
> invalid system ID, OVS will fail to create the bond and warn.
> This behavior seems safer then defaulting to the bridge Ethernet
> Address which may surprise users.
> 
> Bug #8710.
> Signed-off-by: Ethan Jackson <et...@nicira.com>

In the commit message and in a quoted string within the code, I think
that I would write the 'a' in "Ethernet address" in lowercase.

I would document in vswitch.xml that the LACP system ID defaults to
the bridge's Ethernet address if it is not specified.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to