> Is this commit complete? It looks like the following code remains in > bond_check_admissibility():
> > case BM_TCP: > /* TCP balancing has degraded to SLB (otherwise the > * bond->lacp_negotiated check above would have processed this). > * > * Fall through. */ > > whereas I'd expect either a "case BM_TCP: return BV_DROP;" or some > kind of earlier logic similar to Oops, I originally had code like this in a patch that I dropped and failed to backport it. > Does bond_choose_output_slave() need any changes? (Maybe it works > as-is because LACP wouldn't enable any output slaves?) Yes lacp_negotiated is true if and only if LACP has decided at least one slave may be enabled. I orginally explicitly enforced this in bond_choose_output_slave(), but it's unnecessary. Perhaps I should bring that patch back for clarity though? It may be safer than relying on the LACP code as well. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
