On Sat, Dec 9, 2023 at 6:56 AM Yury Tarasievich <yury.tarasiev...@gmail.com>
wrote:
> Hi,
>
> Thank you, Damjan, for the prompt looking into
> the problem.
>
>
It's a pleasure, let's try fix it so nobody else suffers.
> Regarding the matters you address:
>
> If I understand correctly, the configure code
> allows for a separate inclusion of nss (more on
> that at the very end of this message):
>
> --with-system-nss
>
> ...which brings us to the original issue.
>
> I've just rebuilt from start with
> --with-system-ssl and with --with-system-nss
>
It's --with-system-openssl, NOT --with-system-ssl.
> options, but for a while I couldn't even check
> if it actually worked.
>
> Because, when making the final target, i.e.
> instsetoo_native, the 'packaging' script in
> solenv/bin/make_installer.pl, which uses this list:
>
> ... analyzing script:
> /home/me/c/+ooo/aoo45/main/solver/450/unxlngx6.pro/bin/setup_osl.ins
>
> which is dated 2023-08-28 on my system and
> includes, e.g., this:
>
> File gid_File_Lib_Openssl
> Dir = gid_Brand_Dir_Program;
> Name = "libssl.so";
> Styles = (PACKED);
> UnixRights = 444;
> End
>
> ...fails (i.e. the 'packaging' script fails),
> saying this:
>
> ERROR: The following files could not be found:
> ERROR: File not found: libcrypto.so
> ERROR: File not found: libssl.so
>
> ...which obviously wouldn't even be there.
>
> Just for the kicks, I removed those two entries
> (on libcrypt and libssl) from setup_osl.ins (in
> solver, not touching its original in scp2/), and
> the packaging script completed successfully.
>
> Any idea how such things could be fixed? Should
> be fixed? Would be fixed?
>
In main/scp2/source/ooo/makefile.mk, we have this:
---snip---
# if yes or unset (neon not used) -> do not install openssl library!
.IF "$(SYSTEM_OPENSSL)" != "YES"
SCPDEFS+=-DOPENSSL
.ENDIF
---snip---
That determines whether "OPENSSL" is defined.
Then in main/scp2/source/ooo/file_library_ooo.scp we have:
---snip---
#ifdef OPENSSL
File gid_File_Lib_Openssl
TXT_FILE_BODY;
Styles = (PACKED);
Dir = SCP2_OOO_BIN_DIR;
#ifdef WNT
Name = "ssleay32.dll";
#else
Name = "libssl.so";
#endif
End
#endif
#ifdef OPENSSL
File gid_File_Lib_Crypto
TXT_FILE_BODY;
Styles = (PACKED);
Dir = SCP2_OOO_BIN_DIR;
#ifdef WNT
Name = "libeay32.dll";
#else
Name = "libcrypto.so";
#endif
End
#endif
---snip---
So it should look something like this:
1. If you passed --with-system-openssl to ./configure, then SYSTEM_OPENSSL
should be set, you can check that your config.log contains
SYSTEM_OPENSSL='YES'.
2. When you run "source LinuxX86_64.sh" (or whatever that file is) before
building, it populates SYSTEM_OPENSSL into your shell's environment
variables, so you can even run "echo $SYSTEM_OPENSSL" to check.
3. When scp2 is built, it uses the presence of that environment variable to
not populate the preprocessor's OPENSSL define, then since it's not defined
when building main/scp2/source/ooo/file_library_ooo.scp, it should skip
packaging those files.
If it is trying to package them and failing, like in your case, then it
went wrong in at least one of those steps. Please check?
> However, while 'Online Update - Check Now'
> stopped crashing the AOO (i.e. with system SSL
> loaded), the 'Macro Security' stil does nothing,
> so it seems just using --with-system-nss isn't
> enough.
>
Online Update shouldn't be crashing, thank you for reporting that.
Without --enable-category-b, you probably need both --enable-nss-module and
--with-system-nss, but I doubt even that will work. Unless category B is
enabled, all category B modules are apparently disabled, overwriting your
--enable-nss-module. You probably have to --enable-category-b
--with-system-nss --disable-hunspell --disable-hyphen --disable-saxon
--disable-javascript --disable-graphite --disable-coinmp
--disable-category-b-fonts.
> That brings us to the configure script
> functionality. I've heard before that w/r to at
> least category-b, there are to be NO changes. So
> I shouldn't expect the possibility of, like,
> including/enabling category-b stuff piecemeal?
>
> (For myself I'm using such piece-wise inclusion
> for years (as you could glean from my options)
> with no ill effects)
>
Where did you hear this?
>
>
> Thank you for your time anyway, again.
>
> -Yury
>
>
Pleasure Yury.
Damjan
