Okay so there is first check patch failure (code formatting): https://github.com/apache/nuttx/actions/runs/19777139931/job/56671475560?pr=17404
If possible please align with branches already created for PRs and push to them, then I will just pull your changes and proxy to GH ;-) https://github.com/cederom/nuttx/branches -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info On Sat, Nov 29, 2025 at 2:59 AM Tomek CEDRO <[email protected]> wrote: > > Thanks Kerogit :-) > > Your patches are delivered as following PR: > https://github.com/apache/nuttx/pull/17403 > https://github.com/apache/nuttx/pull/17404 > https://github.com/apache/nuttx/pull/17405 > https://github.com/apache/nuttx/pull/17406 > > Please follow discussion and review on the github. > > For future (maintainers please verify): > * Please do NOT bundle several functional changes into a single branch. > * Pull Requests are made from branches. These can have separate git > commits but should be focused on a single functional change (i.e. arch > fix, board fix, add sensor driver, update board to use added sensor). > * If we simply push a branch like that to become a Pull Request it > will contain several different functional changes in different areas > and it will be rejected. > * We work on single functional change per PR (and so thus branch). > * You can name your branches like avrdx_twi_rfc1-1, avrdx_twi_rfc1-2, > avrdx_twi_rfc1-3, so we can push them and convert directly into valid > Pull Requests in correct order of dependencies. > > I had to split that branch into 4 different branches as described > above to create 4 separate PRs that change different functional parts > of the code. That will help us a lot in review :-) > > Take care :-) > Tomek > > -- > CeDeROM, SQ7MHZ, http://www.tomek.cedro.info > > On Fri, Nov 28, 2025 at 3:44 PM <[email protected]> wrote: > > > > Hello, > > > > I would like to submit this patch series for review, comments and > > eventual inclusion - it adds support for Two-Wire interface (I2C and > > SMBus) to AVR DA/DB family of chips. There are also fixes for some bugs. > > Patches are available in a git repository nuttx.git at git.kerogit.eu > > accessible through HTTP/S. (Trying to prevent bot traffic by not posting > > the URL in machine-readable form.) The relevant branch is called > > avrdx_twi_rfc1. > > > > The first part is the I2C driver itself. It only has limited support for > > I2C features - no slave mode, no 10 bit addresses for example (those are > > not supported by hardware directly) but otherwise should be usable. > > > > Second part is a driver for Microchip TC74Ax I2C temperature sensor, it > > was used to develop and test the I2C driver. As for this one, I have a > > question: is there a way of tracking how many users have the device file > > open - or more precisely, how many open descriptors exist? I looked > > around and it seems that some drivers simply do their own counting but > > that feels like something that would fail when the user space forks or > > calls dup or something along those lines. > > > > Third part of the series adds the driver to the example (bread)board - > > breadxavr. > > > > More details about all of these can be found in added documentation and > > also in the Kconfig. > > > > Documentation builds on my system, checkpatch has no complaints. Output > > from test application: > > > > nsh> tc74_test > > tc74_test [4:100] > > nsh> Starting TC74 test > > Temperature read: 23 > > Temperature read: 23 > > > > As previously, I would like to ask someone with GitHub account to change > > this into a pull request. If I forgot/missed something with regards to > > contributing rules, let me know. Other than that, I'll try to keep an > > eye on GitHub. > > > > Thanks.
