> If you can make LVGL optionally NOT generate its own config.h and .config we > could indeed just include the Kconfig and Make.defs (as it is done now).
I think generating the config file would be part of a "toplevel" LVGL build system which we would completely bypass. > maybe allowing LVGL user to supply a header where we could just do "#include > <nuttx/config.h> This should work, for instance MbedTLS has something like this: #if defined(MBEDTLS_USER_CONFIG_FILE) #include MBEDTLS_USER_CONFIG_FILE #endif And then one can just add CFLAGS += -DMBEDTLS_USER_CONFIG_FILE=path/ The only issue I see is symbols redefinition, how can we be sure that every CONFIG_ is unique? Is LVGL going to prefix them with a LVGL_ for example? On Wed, Aug 26, 2020 at 2:03 PM Matias N. <mat...@imap.cc> wrote: > > LVGLs Kconfig in NuttX is used to define macros which are picked up in > lv_conf.h. Indeed this is painful to maintain whenever a new LVGL version > appears and changes lv_conf_template.h. > > Including a child Kconfig is no problem. The issue is that in this case NuttX > controls the build and not LVGL so I'm not sure how you would distribute LVGL > assuming a higher level build system generating the .config and config.h. > > These two files are placed in nuttx root and include/nuttx respectively. The > config.h is included in all source files in NuttX so if this include is made > visible to LVGL itself this would complete integration (maybe allowing LVGL > user to supply a header where we could just do "#include <nuttx/config.h>". > If you can make LVGL optionally NOT generate its own config.h and .config we > could indeed just include the Kconfig and Make.defs (as it is done now). > > Best, > Matias > > On Wed, Aug 26, 2020, at 09:52, Gábor Kiss-Vámosi wrote: > > Hi Matias, > > > I’ve checked the current LVGL KConfig in NuttX and it seems up to date but > > some help messages are quite outdated. I think it’d be awesome to somehow > > use LVGL’s Kconfig to be sure you always have the latest and official > > version. > > > I wonder if it’s possible to simply `rsource` LVGL’s KConfig here > > <https://github.com/apache/incubator-nuttx-apps/blob/master/graphics/lvgl/Kconfig#L13>. > > > Where are the .config and config.h are created? If we can .gitignore them > > from LVGL then I have no problem with it. > > > > Regards, > > Gabor > > > > > > > Matias N. <mat...@imap.cc> ezt írta (időpont: 2020. aug. 26., Sze, 14:20): > >> __ > >> Hi Alan and Gabor, > >> > >> I don't think that LVGL use of Kconfig should bother NuttX's since the > >> build is always self contained in a directory. The positive side is that > >> we could store a defconfig for LVGL on NuttX instead of the lv_conf.h that > >> is now. > >> Of course it would be cool if you could simply do "make menuconfig" on > >> NuttX and have LVGL options appear there, but I believe that would couple > >> LVGL and NuttX build systems which may not be the best idea. I'm not sure > >> if that can be done cleanly (it would always produce one .config and > >> config.h which both would have to read). > >> > >> Best, > >> Matias > >> > >> On Tue, Aug 25, 2020, at 21:22, Alan Carvalho de Assis wrote: > >>> Hi Everyone, > >>> > >>> Mr. Gábor Kiss-Vámosi contacted and told me that LVGL is moving to use > >>> Kconfig: > >>> > >>> "At LVGL we are planning to add a Kconfig file to the main repo but we > >>> are not sure if it will harm the existing Kconfig based projects. > >>> > >>> Could you comment on what your requirements are and what we should > >>> consider in order to allow NuttX to use LVGL's Kcofig file or - if > >>> it's not possible - to make sure it won't bother your Kconfig file?" > >>> > >>> So, I think this is a good opportunity to make NuttX more integrated > >>> with LVGL. Suggestions are welcome. > >>> > >>> Gábor, I added you CC here because I don't know if you are subscribed > >>> to NuttX at Apache Foundation mailing list. > >>> > >>> BR, > >>> > >>> Alan > >>> > >>
