> Is this something we should be concerned about?
Sorry if that came off wrong. I was agreeing with Greg's with the former statement. Not the latter one. David -----Original Message----- From: Brennan Ashton [mailto:bash...@brennanashton.com] Sent: Thursday, July 30, 2020 12:57 PM To: dev@nuttx.apache.org Subject: Re: [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1487: libc: Avoid ctype function to evaluate the argument more than once On Thu, Jul 30, 2020, 12:40 PM David Sidrane <david.sidr...@nscdg.com> wrote: > -1 on more bloat > That is not a constructive vote. No one thinks we should have more bloat. The question is do we need to focus more on this. Some of the changes are due to shortcuts we have taken in the past that are now causing issues. The PR that spurred this is exactly this. The code as it exists is wrong in that it has unexpected side effects which is what Xiao is trying to address. I will acknowledge that there have been other changes where it was more of a complexity trade-off. Even on those there was discussion about the impact. > It is a simple matter to see the cost of a PR if we add bloaty > (https://github.com/google/bloaty) to ci. > Great please file the simple PR to add it. This is not trivial as we need to manage the artifacts from previous builds to do the comparison or double the build time. We heard you last time, but someone has to do to the actual work. --Brennan
