It is a simple matter to see the cost of a PR if we add bloaty
(https://github.com/google/bloaty) to ci.

Great please file the simple PR to add it. This is not trivial as we need to manage the artifacts from previous builds to do the comparison or double the build time. We heard you last time, but someone has to do to the actual
work.

The absolute size of a build by itself is not so useful.  You would need the size BEFORE the change (on the same base)  for comparison with the size AFTER the change.  I assume that bloaty does not have this A to B comparison built in?

I am not a bloaty user so I might not be properly informed.  But from what I see, it is used to determine the cause of code bloat by analyzing the .elf files.  I think that would be a second step.  A first, more trivial step would be to simply detect the size increase, perhaps just running 'size nuttx' and comparing to ... what?  I imagine we would have to keep some artifacts from a previous nightly built to find the A size for the A-to-B comparison.  If we detect a size increase, then bloaty should tell use why.



Reply via email to