On Thu, Jul 30, 2020, 1:02 PM Gregory Nutt <spudan...@gmail.com> wrote:
> > >> It is a simple matter to see the cost of a PR if we add bloaty > >> (https://github.com/google/bloaty) to ci. > >> > > Great please file the simple PR to add it. This is not trivial as we need > > to manage the artifacts from previous builds to do the comparison or > double > > the build time. We heard you last time, but someone has to do to the > actual > > work. > > > The absolute size of a build by itself is not so useful. You would need > the size BEFORE the change (on the same base) for comparison with the > size AFTER the change. I assume that bloaty does not have this A to B > comparison built in? > Exactly which is why we would need to store the bloaty information on master so the CI could fetch it and show the changes. This is why it's not "simple". Bloaty supports the smart comparison, but you have to supply the information from it's last run. I'm happy to put it on my backlog I think it's a good idea, but it won't happen from me for some time. --Brennan >
