+1 In my circles, changing method params is a bad practice. Enforcement of rules is key - I do the same thing Manfred, fail the build on a set of FindBugs, PMD, and CheckStyle violations. Really makes coders adhere!
On Fri, May 23, 2014 at 10:15 PM, Manfred Moser <manf...@mosabuam.com>wrote: > I totally agree with William here. I also think that any standard that is > not enforced easily is pointless. Thats why I implemented the checkstyle > verification to be part of the default build in the android maven plugin > (and other projects). I find this tremendously helpful. It removes any > doubts on the potentially committer side. Its gotta build.. > > manfred > > William Ferguson wrote on 23.05.2014 18:10: > > >> > >> parameters and local variables are not considered final: there is > nothing > >> wrong > >> > > with modifying their value, and nothing good to get by forcing them to be > >> final > >> > > > > But there *is* value is defining them to be final. > > > > If you as the programmer know that a value should never change, then by > > denoting it as final you can enforce that it is not inadvertently > modified > > by someone else. If they deem that the restriction needs to be loosened > > because requirements have changed then they can do so. > > > > It is just like specifying an assertion. It is about code correctness and > > less failures. > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
