Le lundi 19 mai 2014 13:30:57 William Ferguson a écrit : > Hervé Boutemy <https://plus.google.com/u/0/107251243568189719606?prsrc=4> > said: > notice there are a few places where coding conventions are not respected: > this would be great if you could have a look (previous comments are more > important :) ) > see http://maven.apache.org/developers/conventions/code.html for more > information, and tooling for automatic IDE handling > > > I thought I was adhering. Thought I had configured IntelliJ with an > appropriate checkstyle config, but I'll apply it again. Two questions: > > 1) Is there no automatic checkstyle verification as part of the build? We > use it in the android-maven-plugin and I though it was standard practice > across the Maven projects. it's only done on site generation, and you can simply ignore the result
does android-maven-plugin have more aggressive configuration? > > 2) Why is the following one of the Java code conventions? Why would you > remove that information from the compiler? I always work to the exact > opposite of that unless I need to conform with a tool that uses reflection > and can't handle final variables. > > - *Modifier*: Avoid using final modifier on all member variables and > arguments. I don't understand what you're talking about here Regards, Hervé > > > William --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
