[ 
https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831686#comment-13831686
 ] 

Erick Erickson commented on SOLR-5488:
--------------------------------------

OK, I incorporated your changes into my local copy, seeing what you are.

It's probably worth keeping the assertEquals idiom in mind with
doubles & such, rather than assertTrue(expected == acutal), it's probably more
robust to do something like
assertEquals("your message here", expected, actual, epsilon)

where "epsilon it the amount the values can differ by, i.e.
Math.abs(expected - actual) < epsilon

That said, I see result == 17.38 and 
                       calculated == 29.91

so the assertEquals bit isn't going to be super helpful...

I can say that the raw response is consistent here:

  <lst name="avr">
    <double name="mean">17.38</double>
    <double name="meanc">29.91</double>
    <double name="sum">2991.0</double>
    <double name="sumc">2991.0</double>
  </lst>


> Fix up test failures for Analytics Component
> --------------------------------------------
>
>                 Key: SOLR-5488
>                 URL: https://issues.apache.org/jira/browse/SOLR-5488
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.7
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-5488.patch, SOLR-5488.patch
>
>
> The analytics component has a few test failures, perhaps 
> environment-dependent. This is just to collect the test fixes in one place 
> for convenience when we merge back into 4.x



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to