[
https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832014#comment-13832014
]
Houston Putman commented on SOLR-5488:
--------------------------------------
[~erickerickson], addressing some of what IntelliJ found: (You can ignore them
if they were already fixed.)
??2> ExpressionFactory about line 166. The escapedCharacter variable is always
false in the test, at the end of the loop there's this code then
!escapedCharacter at the top:
if (escapedCharacter)
\{ escapedCharacter=false; \}??
Escaped Character is completely unnecessary. It was something that I added to
escape things in strings, such as '(' and ',', but I realized that escaping
these characters was not necessary. So any use of it can be removed.
??3> FieldFacetTest, line 1191. The variable 'b' cannot be false inside the for
loop. This doesn't matter, but it's useless there.??
True
??StatsCollectionSupplierFactory, line 454. Claim is that src can never be a
DateFieldSource. DateFieldSource extends LongFieldSource which is tested
above.??
I'm glad this got caught, and I'm curious as to why it doesn't break things...
But it should easily be fixed by checking if it is a DateFieldSource before
checking if it is a LongFieldSource.
??6> Mark's comment, this line is removing something other than a String from a
Set<String>:
if (qfr.getDependencies().remove(queryFacet)) \{??
It should be :
{{if (qfr.getDependencies().remove(queryFacet.getName())) \{}}
Sorry I would update these and make a patch myself, but my desktop is currently
not cooperating.
> Fix up test failures for Analytics Component
> --------------------------------------------
>
> Key: SOLR-5488
> URL: https://issues.apache.org/jira/browse/SOLR-5488
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.0, 4.7
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch
>
>
> The analytics component has a few test failures, perhaps
> environment-dependent. This is just to collect the test fixes in one place
> for convenience when we merge back into 4.x
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
