[ 
https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831470#comment-13831470
 ] 

Erick Erickson commented on SOLR-5488:
--------------------------------------

Thanks, Mark! Sorry I let the forbidden API call slip through...

OK, I'm going to try to summarize where we're at, quite a bit happened over the 
weekend:

1> Mark, Dawid and I kicked things around and committed some changes that we 
think are helpful. It would be good if people who know the code 
([~houstonputman] [~Steven bower] are you listening :) ) would review the 
changes to see if they do violence to the intent of the code.

2> There are now two tests that are @Ignore'd. I have no clue whether these are 
just test errors or point to deeper issues. Again, if Houston and/or Steven can 
look at them to see and render a judgement call, that would be good.

3> The major take-away is that so far I don't think the test problems we were 
seeing are due to obscure float conversions, compiler differences, etc, but 
that the string operations _in the tests_ were producing bogus failures. I'll 
defer to people who know the code. Un-ignoring the two tests and understanding 
the consequences is key here.

4> We aren't seeing failures at this point, at least since yesterday. But two 
tests are ignored. If we can get a resolution to the two @Ignore'd tests, then 
I can probably commit this to 4x next week. [~Mark Miller][~Dawid Weiss] or 
anyone else for that matter, does that seem reasonable? Premature?

> Fix up test failures for Analytics Component
> --------------------------------------------
>
>                 Key: SOLR-5488
>                 URL: https://issues.apache.org/jira/browse/SOLR-5488
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.7
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-5488.patch, SOLR-5488.patch
>
>
> The analytics component has a few test failures, perhaps 
> environment-dependent. This is just to collect the test fixes in one place 
> for convenience when we merge back into 4.x



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to