[
https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707528#comment-16707528
]
Gus Heck commented on SOLR-12801:
---------------------------------
I believe such an await can be achieved with a close hook, at which point we
can hold onto the executor and save some tiny amount of GC & processing too.
[~dsmiley] had convinced me that such a close hook was just added complexity
(hence the large comment in the code clarifying the decision on that point).
Will you be satisfied if a close hook is added to ensure the test can't end
without closing the executor?
Code with Comment for reference:
https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=blob;f=solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java;h=cc1ddb893b9e5dad5e0c3a22613248ef9e67dc96;hb=cf4d749#l244
> Fix the tests, remove BadApples and AwaitsFix annotations, improve env for
> test development.
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-12801
> URL: https://issues.apache.org/jira/browse/SOLR-12801
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Critical
> Time Spent: 1h
> Remaining Estimate: 0h
>
> A single issue to counteract the single issue adding tons of annotations, the
> continued addition of new flakey tests, and the continued addition of
> flakiness to existing tests.
> Lots more to come.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
