[
https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706446#comment-16706446
]
Gus Heck commented on SOLR-12801:
---------------------------------
[[email protected]], based on the changes you made to
TimeRoutedAliasUpdateProcessorTest I believe you have broken the intended
functionality with
[https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a3ec5b5]
The specific intention in that test is that we are verifying that the request
does not wait for the executor to finish before returning. Where you changed
the collection count from 3 to 4 the test was explicitly testing that a new
collection was not yet visible. The test expects that it won't be visible until
after we wait for it to appear, which generally safe since collection creation
typically takes 1-2 seconds, and the listing of aliases is typically very fast.
Also your change creates a serious bug wherein pre-emptive collection creation
will always be triggered for every doc potentially preemptively creating an
indefinite number of collections, this bug masked the fact you changed later
tests to higher than expected numbers and should have failed.
I'm going to revert that commit to restore correct functionality, and add
additional assertions that need to pass.
If this test/technique seems to be a source of instability (the assumptions
about timing could be bad under high load), then we'll need to find a solution
that also passes the additional assertions
> Fix the tests, remove BadApples and AwaitsFix annotations, improve env for
> test development.
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-12801
> URL: https://issues.apache.org/jira/browse/SOLR-12801
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Critical
> Time Spent: 1h
> Remaining Estimate: 0h
>
> A single issue to counteract the single issue adding tons of annotations, the
> continued addition of new flakey tests, and the continued addition of
> flakiness to existing tests.
> Lots more to come.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
