Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/443#discussion_r214541721
  
    --- Diff: 
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java 
---
    @@ -54,24 +54,26 @@
       private final DocSet childDocSet;
       private final int limit;
       private final boolean isNestedSchema;
    +  private final SolrReturnFields childReturnFields;
     
    -  //TODO ought to be provided/configurable
    -  private final SolrReturnFields childReturnFields = new 
SolrReturnFields();
    -
    -  ChildDocTransformer(String name, BitSetProducer parentsFilter,
    -                      DocSet childDocSet, boolean isNestedSchema, int 
limit) {
    +  ChildDocTransformer(String name, BitSetProducer parentsFilter, DocSet 
childDocSet,
    +                      SolrReturnFields returnFields, boolean 
isNestedSchema, int limit) {
         this.name = name;
         this.parentsFilter = parentsFilter;
         this.childDocSet = childDocSet;
         this.limit = limit;
         this.isNestedSchema = isNestedSchema;
    +    this.childReturnFields = returnFields!=null? returnFields: new 
SolrReturnFields();
       }
     
       @Override
       public String getName()  {
         return name;
       }
     
    +  @Override
    +  public boolean needsSolrIndexSearcher() { return true; }
    --- End diff --
    
    +1 nice catch! 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to