Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542527
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -243,11 +250,39 @@ private void testChildDocNonStoredDVFields() throws
Exception {
"fl", "*,[child parentFilter=\"subject:parentDocument\"]"), test1);
assertJQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
- "fl", "subject,[child parentFilter=\"subject:parentDocument\"
childFilter=\"title:foo\"]"), test2);
+ "fl", "intDvoDefault, subject,[child
parentFilter=\"subject:parentDocument\" childFilter=\"title:foo\"]"), test2);
assertJQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
- "fl", "subject,[child parentFilter=\"subject:parentDocument\"
childFilter=\"title:bar\" limit=2]"), test3);
+ "fl", "intDvoDefault, subject,[child
parentFilter=\"subject:parentDocument\" childFilter=\"title:bar\" limit=2]"),
test3);
+
+ }
+
+ private void testChildReturnFields() throws Exception {
+ assertJQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
+ "fl", "*,[child parentFilter=\"subject:parentDocument\"
fl=\"intDvoDefault,child_fl:[value v='child_fl_test']\"]"),
+ "/response/docs/[0]/intDefault==42",
+ "/response/docs/[0]/_childDocuments_/[0]/intDvoDefault==42",
+
"/response/docs/[0]/_childDocuments_/[0]/child_fl=='child_fl_test'");
+
+ try(SolrQueryRequest req = req("q", "*:*", "fq",
"subject:\"parentDocument\" ",
--- End diff --
Do you know XPath? assertQ takes xpath expressions that is powerful enough
to do everything you are asserting here in less code. (assertQ is used in a
*ton* of tests; plenty of examples to learn from). The assertJQ thing is less
powerful. You don't *have* to rewrite it but it's at least worth being aware
for future assertions.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
