Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542262
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java ---
@@ -114,4 +114,27 @@ public void transform(SolrDocument doc, int docid,
float score) throws IOExcepti
public String toString() {
return getName();
}
+
+ /**
+ * Trivial Impl that ensure that the specified field is requested as an
"extra" field,
+ * but then does nothing during the transformation phase.
+ */
+ public static final class NoopFieldTransformer extends DocTransformer {
--- End diff --
Oh woops; I recommended you do this but overlooked it's not *just* a no-op;
it's doing this extra field requesting task. Well I suppose it's okay; not a
big deal. Alternatively, this could changed to be *just* a no-op, and then the
former impl in RawValueTransformerFactory.java could exist as a subclass that
is a bit simpler.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
