[
https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805150#comment-15805150
]
Mark Miller commented on SOLR-9928:
-----------------------------------
The argument for hiding and doing a single unwrap everywhere seems to be that
this factory tries to inject itself in an abnormal way, rather than counting on
being configured. It almost looks like it hides outside the cache - and so the
unwrap would pass the cache key directory that impls may expect to get passed.
> MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
> --------------------------------------------------------------------
>
> Key: SOLR-9928
> URL: https://issues.apache.org/jira/browse/SOLR-9928
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: master (7.0), 6.4
> Reporter: Mike Drob
> Assignee: Andrzej Bialecki
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9928.patch, SOLR-9928.patch
>
>
> MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead
> of super. Trivial patch forthcoming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
