[ 
https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805115#comment-15805115
 ] 

Mark Miller commented on SOLR-9928:
-----------------------------------

Previously non of the impls unwrapped more than One layer and they only did it 
for nrt caching dir. I recently fixed it so they unwrap Filtered dirs multiple 
layers. So we should remove the unwrapping probably.  The consistency argument 
is that it's confusing to only do some
Methods. It indicates the unwrapping is unnecessary cruft where it used. Or 
it's intentionally trying to hide the dir and failing to in some cases. Doesn't 
make sense in any scenario. 

> MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
> --------------------------------------------------------------------
>
>                 Key: SOLR-9928
>                 URL: https://issues.apache.org/jira/browse/SOLR-9928
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: master (7.0), 6.4
>            Reporter: Mike Drob
>            Assignee: Andrzej Bialecki 
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9928.patch, SOLR-9928.patch
>
>
> MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead 
> of super. Trivial patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to