[
https://issues.apache.org/jira/browse/SOLR-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804976#comment-15804976
]
Mike Drob commented on SOLR-9928:
---------------------------------
Ran some tests locally and it looks like the only two specializations both
unwrap properly internally, so we don't have to worry about it here. Needed to
unwrap in renameWithOverwrite because the implementations there _did not_
unwrap before trying to use. I don't have strong opinions about the consistency
argument here.
However, while looking into this, I discovered a bug in
StandardDirectoryFactory::move, filed as SOLR-9937
> MetricsDirectoryFactory::renameWithOverwrite incorrectly calls super
> --------------------------------------------------------------------
>
> Key: SOLR-9928
> URL: https://issues.apache.org/jira/browse/SOLR-9928
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: master (7.0), 6.4
> Reporter: Mike Drob
> Assignee: Andrzej Bialecki
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9928.patch, SOLR-9928.patch
>
>
> MetricsDirectoryFactory::renameWithOverwrite should call the delegate instead
> of super. Trivial patch forthcoming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
