[
https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654321#comment-14654321
]
Uwe Schindler commented on LUCENE-6417:
---------------------------------------
I fixed the build now to have all required license files (will attach patch).
We still have one problem: The ANTLR code has now many subclasses which miss
javadocs. Our Javadocs-Linter now breaks on precommit with:
{noformat}
-documentation-lint:
[echo] checking for broken html...
[jtidy] Checking for broken html (such as invalid tags)...
[delete] Deleting directory C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr1\lucene\build\jtidy_tmp
[echo] Checking for broken links...
[exec]
[exec] Crawl/parse...
[exec]
[exec] Verify...
[exec]
[exec]
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptVisitor.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/expressions.js.JavascriptParser.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.AddsubContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolcompContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BooleqneContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BworContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwshiftContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwxorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.CompileContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ConditionalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ExternalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.MuldivContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.NumericContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.PrecedenceContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.UnaryContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.CompileContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ConditionalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolcompContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.NumericContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.AddsubContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.UnaryContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.PrecedenceContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.MuldivContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ExternalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwshiftContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BworContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwxorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BooleqneContext.html
[exec]
[exec]
file:///build/docs/expressions/org/apache/lucene/expressions/js/package-summary.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/expressions.js.JavascriptParser.html
[exec]
[exec]
file:///build/docs/expressions/org/apache/lucene/expressions/js/package-use.html
[exec] BROKEN LINK:
file:///build/docs/core/org/apache/lucene/expressions.js.JavascriptParser.html
[exec]
[exec]
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptCompiler.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.AddsubContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolcompContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BooleqneContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BworContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwshiftContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwxorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.CompileContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ConditionalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ExternalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.MuldivContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.NumericContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.PrecedenceContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.UnaryContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.CompileContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.PrecedenceContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.NumericContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ExternalContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.UnaryContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.MuldivContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.AddsubContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwshiftContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolcompContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BooleqneContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BwxorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BworContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolandContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.BoolorContext.html
[exec] BROKEN LINK:
file:///build/docs/expressions/org/apache/lucene/expressions/js/JavascriptParser.ConditionalContext.html
[exec]
[exec] Broken javadocs links were found!
{noformat}
Indeed the problem is: The main class is package protected, but the inner
classes generated by ANTLR are public, which violates visibility. We should
also make them package protected. I am not sure how to do that without regular
expressions in "ant regenerate".
> Upgrade ANTLR to version 4.5
> ----------------------------
>
> Key: LUCENE-6417
> URL: https://issues.apache.org/jira/browse/LUCENE-6417
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jack Conradson
> Assignee: Uwe Schindler
> Attachments: LUCENE-6471.patch, LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several
> features that will improve the existing grammars. The main improvement would
> be the allowance of left-hand recursion in grammar rules which will reduce
> the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions
> work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
