[ 
https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654604#comment-14654604
 ] 

Jack Conradson commented on LUCENE-6417:
----------------------------------------

[~rcmuir] then maybe the best solution is to drop the visitor and parse the 
tree as before?  As a possible third option, I checked to see if it was 
possible to easily modify the string template files used to generate the code 
from the grammars, but there's no easy way to point to a custom one.  We might 
be able to still do this, but it would either be through some fragile classes 
that I don't anticipate were meant to be overridden or by injecting a custom 
template file into a copied version of the antler 4 jar -- definitely not a 
pretty solution.

> Upgrade ANTLR to version 4.5
> ----------------------------
>
>                 Key: LUCENE-6417
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6417
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jack Conradson
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5.  This version adds several 
> features that will improve the existing grammars.  The main improvement would 
> be the allowance of left-hand recursion in grammar rules which will reduce 
> the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions 
> work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to