[
https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642091#comment-14642091
]
Michael McCandless commented on LUCENE-6417:
--------------------------------------------
Thanks [~jdconradson], it looks like a lot changed between ANTLR 3.5 and 4.5!
I confirmed tests pass with your patch, then I ran {{ant run-antlr}} in the
expressions module and tests still pass. I don't understand all the changes
but I trust you do! Is this ready to be committed? Maybe [~rcmuir] wants to
review this...
I'll fix the jar licenses/sha1 issues, but {{ant precommit}} is angry about
this:
{noformat}
-ecj-javadoc-lint-src:
[mkdir] Created dir: /tmp/ecj949391657
[ecj-lint] Compiling 21 source files to /tmp/ecj949391657
[ecj-lint] ----------
[ecj-lint] 1. ERROR in
/l/antlr/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptParserErrorStrategy.java
(at line 72)
[ecj-lint] * @throws RecognitionException
[ecj-lint] ^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Javadoc: Description expected after this reference
[ecj-lint] ----------
[ecj-lint] 1 problem (1 error)
{noformat}
What description should I add...?
> Upgrade ANTLR to version 4.5
> ----------------------------
>
> Key: LUCENE-6417
> URL: https://issues.apache.org/jira/browse/LUCENE-6417
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jack Conradson
> Attachments: LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several
> features that will improve the existing grammars. The main improvement would
> be the allowance of left-hand recursion in grammar rules which will reduce
> the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions
> work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
