[
https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989641#comment-12989641
]
Michael McCandless commented on LUCENE-2831:
--------------------------------------------
Patch looks good!
But, can you change the new assert to say something like "cannot access top
context when IS is a leaf reader" or something? Right now if you trip that
assert it's like not clear what's gone wrong...
And I think either remove the jdoc on that method, or, clarify that it's only
sugar when IS is not based on an leaf reader?
I really don't like this schitzo IS though ;) Sometimes it's top reader
sometimes it's leaf reader. But, the schitzo IS's should never "escape" out of
the top IS that has an ES.
> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
> Key: LUCENE-2831
> URL: https://issues.apache.org/jira/browse/LUCENE-2831
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-2831-nuke-SolrIndexReader.patch,
> LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831-recursion.patch,
> LUCENE-2831-recursion.patch, LUCENE-2831-recursion.patch,
> LUCENE-2831-recursion.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR,
> boolean, boolean) we should / could revise the API and pass in a struct that
> has parent reader, sub reader, ord of that sub. The ord mapping plus the
> context with its parent would make several issues way easier. See
> LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
