[
https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989266#comment-12989266
]
Simon Willnauer commented on LUCENE-2831:
-----------------------------------------
bq. Simon can you check this? Thanks.
this seems wrong since you don't maintain the actual hierarchy between parent
and child. We need this for certain assertions down the road. Yet, what's
problematic here is that it takes more than one leaf which kills the sematics
of methods like IS#docFreq() as you figured out on IRC. If the parents reader
is used for a searcher that only operates on partial leaves we have a problem.
I think we need to shrapen that ctor to only take one sub and use the subs
reader as the IS's reader. This should make the semantics clear. Ideally we
should also make this ctor private one the users of it are "fixed". But for now
{code}
IndexSearcher(ReaderContext ctx, AtomicReaderContext leaf)
...
{code}
should be fine ey?
> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
> Key: LUCENE-2831
> URL: https://issues.apache.org/jira/browse/LUCENE-2831
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-2831-nuke-SolrIndexReader.patch,
> LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831-recursion.patch,
> LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR,
> boolean, boolean) we should / could revise the API and pass in a struct that
> has parent reader, sub reader, ord of that sub. The ord mapping plus the
> context with its parent would make several issues way easier. See
> LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
