[
https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989504#comment-12989504
]
Yonik Seeley commented on LUCENE-2831:
--------------------------------------
bq. fixed QueryValueSource. Since that class directly controls when it invokes
weight.scorer, I think it's safe to just pass the top context?
Yep. Note that it's fallback code in any case - the normal path is that it
should have already been weighted and the weight will be found in the context.
> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
> Key: LUCENE-2831
> URL: https://issues.apache.org/jira/browse/LUCENE-2831
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-2831-nuke-SolrIndexReader.patch,
> LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831-recursion.patch,
> LUCENE-2831-recursion.patch, LUCENE-2831-recursion.patch, LUCENE-2831.patch,
> LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch,
> LUCENE-2831.patch, LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch,
> LUCENE-2831_transition_to_atomicCtx.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR,
> boolean, boolean) we should / could revise the API and pass in a struct that
> has parent reader, sub reader, ord of that sub. The ord mapping plus the
> context with its parent would make several issues way easier. See
> LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
