[
https://issues.apache.org/jira/browse/SOLR-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246697#comment-14246697
]
Erick Erickson commented on SOLR-6840:
--------------------------------------
Alan:
Right, thanks. Before I went off the deep end I wanted to be sure of the
intent.
bq: I don't think you can just remove <cores> entries, as there were a whole
bunch of other attributes specified on it in addition to listing the cores.
Of course I can't blindly remove all <cores... entries and expect it to "just
work". But by doing so I've unambiguously found all of the places where we need
to do something to get tests to pass though ;)
bq:.... isPersistent() should just be removed.
Great, that was the big question for me, I'll give that a whirl tonight. Which
will have the consequence of finding/modifying anything that uses it. Which
_should_ prevent these things from being written in the future. Which _should_
cause all the tests that pass with copying junk around to pass.... And on to
the next failing tests...
bq: Ideally you shouldn't have to write properties files anywhere for tests
Agreed, and with the env var substitution trick I don't have to, just have to
work out the isPersistent bit.
Anyway, thanks. The crucial bit was your statement that "Persistence makes no
sense". And glad I am that it's gone, getting it right was a major pain. I'm
not entirely sure that continues to work on the individual core.properties
files, but theoretically anything that was changing them had to create a tmp
directory first someplace b/c the test framework wouldn't let them write to the
source tree.
Anyway, probably a day or two before I can get any more done...
> Remove legacy solr.xml mode
> ---------------------------
>
> Key: SOLR-6840
> URL: https://issues.apache.org/jira/browse/SOLR-6840
> Project: Solr
> Issue Type: Task
> Reporter: Steve Rowe
> Assignee: Erick Erickson
> Priority: Blocker
> Fix For: 5.0
>
> Attachments: SOLR-6840.patch
>
>
> On the [Solr Cores and solr.xml
> page|https://cwiki.apache.org/confluence/display/solr/Solr+Cores+and+solr.xml],
> the Solr Reference Guide says:
> {quote}
> Starting in Solr 4.3, Solr will maintain two distinct formats for
> {{solr.xml}}, the _legacy_ and _discovery_ modes. The former is the format we
> have become accustomed to in which all of the cores one wishes to define in a
> Solr instance are defined in {{solr.xml}} in
> {{<cores><core/>...<core/></cores>}} tags. This format will continue to be
> supported through the entire 4.x code line.
> As of Solr 5.0 this form of solr.xml will no longer be supported. Instead
> Solr will support _core discovery_. [...]
> The new "core discovery mode" structure for solr.xml will become mandatory as
> of Solr 5.0, see: Format of solr.xml.
> {quote}
> AFAICT, nothing has been done to remove legacy {{solr.xml}} mode from 5.0 or
> trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
