[
https://issues.apache.org/jira/browse/SOLR-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246466#comment-14246466
]
Alan Woodward commented on SOLR-6840:
-------------------------------------
I don't think you can just remove <cores> entries, as there were a whole bunch
of other attributes specified on it in addition to listing the cores.
Persistence makes no sense with the new setup, as the information in ConfigSolr
is immutable for the lifetime of the container. So really isPersistent()
should just be removed.
Ideally you shouldn't have to write properties files anywhere for tests (unless
you're explicitly testing the core discovery logic). TestHarness and/or
SolrTestCaseJ4 should have their own CoresLocator implementation that returns a
CoreDescriptor with the appropriate schema and config settings. The whole
point of the CoresLocator abstraction is that you're not tied to any particular
file format for testing.
> Remove legacy solr.xml mode
> ---------------------------
>
> Key: SOLR-6840
> URL: https://issues.apache.org/jira/browse/SOLR-6840
> Project: Solr
> Issue Type: Task
> Reporter: Steve Rowe
> Assignee: Erick Erickson
> Priority: Blocker
> Fix For: 5.0
>
> Attachments: SOLR-6840.patch
>
>
> On the [Solr Cores and solr.xml
> page|https://cwiki.apache.org/confluence/display/solr/Solr+Cores+and+solr.xml],
> the Solr Reference Guide says:
> {quote}
> Starting in Solr 4.3, Solr will maintain two distinct formats for
> {{solr.xml}}, the _legacy_ and _discovery_ modes. The former is the format we
> have become accustomed to in which all of the cores one wishes to define in a
> Solr instance are defined in {{solr.xml}} in
> {{<cores><core/>...<core/></cores>}} tags. This format will continue to be
> supported through the entire 4.x code line.
> As of Solr 5.0 this form of solr.xml will no longer be supported. Instead
> Solr will support _core discovery_. [...]
> The new "core discovery mode" structure for solr.xml will become mandatory as
> of Solr 5.0, see: Format of solr.xml.
> {quote}
> AFAICT, nothing has been done to remove legacy {{solr.xml}} mode from 5.0 or
> trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
