[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095674#comment-14095674
]
Hoss Man commented on SOLR-2894:
--------------------------------
Whew ... ok, that diff looks much better.
I'm still curious though about what exactly your comparisons look like ... how
"old" is the version of the patch you are comparing with?
Depending on how old it is, some of the bugs we've fixed over hte last few
months could totally explain the perf change (ie: it may have been fast, but
the numbers may be wrong and/or prone to infinite looping)
Specific examples i'm thinking of where the gains in correctness would have
definitely impacted performance...
* the int overflow bug fixed ~ 16/Jul/14 13:58 prevented a bunch of refinement
* if you use facet.offset: not enough refinement happening until ~ 28/Jul/14
18:54
* if you use facet.missing + facet.mincount: sub-pivots of missing may not have
been refined correctly until ~ 29/Jul/14 10:44
* if you ever use facet.sort=index: refinement wasn't happening until ~
04/Aug/14 09:18
However: if you're comparing my latest patch against the last patch
[~andrew.muldowney] uploaded (~ 18/Jul/14 08:11) and if you don't use
facet.offset, or facet.missing, or facet.mincount, or facet.sort=index in any
of those queries ... then i'm surprised that you would see much perf difference.
----
My current thinking is that we should move forward with getting this committed
to trunk, let it soak for a few days and get hammered by jenkins and then move
from there to backport to 4x. We can always revisit performance improvements
later, now that we (in my opinion anyway) have decent confidence in the
correctness of behavior. (and it's not like the performance is abismal)
Does anyone have concerns with moving forward and revisiting questions about
performance improvements in other issues?
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894_cloud_test.patch, dateToObject.patch,
> pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
