[
https://issues.apache.org/jira/browse/SOLR-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055706#comment-14055706
]
Gregory Chanan commented on SOLR-5656:
--------------------------------------
autoReplicaFailoverBadNodeExpiration: This name is a bit confusing -- from just
name I can't figure out if this is the time until a node that has been marked
bad is retried or until we stop trying once we detect a node is bad. Maybe
something like autoReplicaFailoverBadNodeTimeUntilRetry?
Overseer.java:
{code}
Line 356: System.err.println("Process msg " + message);
{code}
You meant to leave this in?
{code}
660: //if (!checkCollectionKeyExistence(message)) return clusterState;
{code}
why is this commented out?
OverseerAuthReplicaFailoverThread.java:
{code}
Line 82: private static Integer lastClusterStateVersion;
{code}
should be volatile if static? Why static?
{code}
Line 293: static String getBestCreateUrl(ZkStateReader zkStateReader,
DownReplica badReplica) {
{code}
The API is a bit confusing, b/c this is the only function that takes a
ZkStateReader -- I think this is just b/c you want to test this function. Can
the test just create one of these objects but not start it to simplify the API?
ConfigSolr.java:
{code}Line 295: SOLR_AUTOREPLICAFAILOVER, {code}
Is this meant to be here? There's no accessor? I think it's only controlled
based on what's in the request?
ConfigSolrXml.java:
{code}
Line 120: propMap.put(CfgProp.SOLR_AUTOREPLICAFAILOVER,
doSub("solr/solrcloud/bool[@name='genericCoreNodeNames']"));
{code}
This looks wrong -- -- should be
{code}solr/solrcloud/bool[@name='autoReplicaFailover']{code}
ConfigSolrXmlOld.java:
{code}
Line 168: config.getVal("solr/cores/@autoReplicaFailoverWaitAfterExperation",
false));
{code}
Expiration
log4j.properties:
{code}
Line 29: log4j.logger.org.apache.solr.common.cloud.ClusterStateUtil=DEBUG
{code}
we want this on for every test?
> Add autoAddReplicas feature for shared file systems.
> ----------------------------------------------------
>
> Key: SOLR-5656
> URL: https://issues.apache.org/jira/browse/SOLR-5656
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-5656.patch, SOLR-5656.patch, SOLR-5656.patch
>
>
> When using HDFS, the Overseer should have the ability to reassign the cores
> from failed nodes to running nodes.
> Given that the index and transaction logs are in hdfs, it's simple for
> surviving hardware to take over serving cores for failed hardware.
> There are some tricky issues around having the Overseer handle this for you,
> but seems a simple first pass is not too difficult.
> This will add another alternative to replicating both with hdfs and solr.
> It shouldn't be specific to hdfs, and would be an option for any shared file
> system Solr supports.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
